Skip to content

Bump dependency versions + Add ncc build #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bump dependency versions + Add ncc build #10

wants to merge 5 commits into from

Conversation

masonjlegere
Copy link
Contributor

@masonjlegere masonjlegere commented Mar 17, 2023 •
edited
Loading

Description

Bumping dependency versions to address security vulnerabilities:

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Had issues with running the action using node_modules so updated the build to use ncc with the modified entry point of dist/index.js

Verification

Ran action against this branch to trigger a test:

jobs:
  run_api_test:
    runs-on: ubuntu-latest
    name: Execute RapidAPI API Tests
    steps:
    - name: Execute Tests
      id: tstExec
      uses: RapidAPI/gh-api-testing-trigger@bump-version
      with:
        test: 'test_c57e975c-c75b-427d-8c97-77103b7ff7fc'
        location: 'AWS-US-EAST-1'
    - name: Show Results
      run: echo "The test took ${{ steps.tstExec.outputs.time }}ms to run"; echo "The test result was ${{ steps.tstExec.outputs.computedStatus }}"; echo "View Report - ${{ steps.tstExec.outputs.reportUrl }}"

and executed successfully
Screen Shot 2023-03-17 at 3 44 25 PM

@masonjlegere masonjlegere marked this pull request as ready for review March 17, 2023 22:48
@masonjlegere masonjlegere requested a review from LMS007 March 17, 2023 22:48
@masonjlegere masonjlegere changed the title Bump version Bump dependency version Mar 17, 2023
@masonjlegere masonjlegere changed the title Bump dependency version Bump dependency versions + Add ncc build Mar 17, 2023
LMS007
LMS007 approved these changes Mar 17, 2023
View reviewed changes
Copy link

@LMS007 LMS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough! thank you Mason

a-cong
a-cong reviewed Mar 17, 2023
View reviewed changes
package-lock.json
@@ -1,46 +1,68 @@
{
"name": "RapidAPI-testing-github-action",
"version": "1.0.0",
"lockfileVersion": 1,
"version": "0.0.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait why was it 1.0.0?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion, just to get start off on a normal version number. This PR does not warrant a major version change, but we probably should have started with 1.x so I figured we would just move it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@LMS007 LMS007 LMS007 approved these changes

@a-cong a-cong a-cong left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masonjlegere @LMS007 @a-cong